svn commit: r777963 - /incubator/log4php/trunk/src/main/php/Logger.php

[grobmeier]

Author: grobmeier
Date: Sat May 23 16:59:30 2009
New Revision: 777963

URL: http://svn.apache.org/viewvc?rev=777963&view=rev
Log:
added TODOs, removed unused and not implemented methods

Modified:
    incubator/log4php/trunk/src/main/php/Logger.php

Modified: incubator/log4php/trunk/src/main/php/Logger.php
URL: 
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/Logger.php?rev=777963&r1=777962&r2=777963&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/Logger.php (original)
+++ incubator/log4php/trunk/src/main/php/Logger.php Sat May 23 16:59:30 2009
@@ -35,6 +35,8 @@
  /*
   * TODO:
   * Localization: setResourceBundle($bundle) : not supported
+  * Localization: getResourceBundle: not supported
+  * Localization: getResourceBundleString($key): not supported
   * Localization: l7dlog($priority, $key, $params, $t) : not supported
   */
 class Logger {
@@ -230,7 +232,8 @@
         * @param LoggerFactory $factory a {...@link LoggerFactory} instance or 
null
         * @return Logger
         * @static 
-        */        
+        */
+        // TODO: remove method? confusing design          
        public function getLogger($name, $factory = null) {
                return LoggerManager::getLogger($name, $factory);
        }
@@ -260,23 +263,10 @@
        }          
                  
        /**
-        * Return the inherited ResourceBundle for this category.
-        */
-       public function getResourceBundle() {
-               return;
-       } 
-
-       /**
-        * Returns the string resource corresponding to key in this category's 
inherited resource bundle.
-        */
-       public function getResourceBundleString($key) {
-               return;
-       } 
-
-       /**
         * Return the root of the default category hierarchy.
         * @return LoggerRoot
         */
+        // TODO: remove method? confusing design
        public function getRoot() {
                return LoggerManager::getRootLogger();
        } 
@@ -286,7 +276,8 @@
         * @return LoggerRoot
         * @static 
         */        
-       public function getRootLogger() {
+        // TODO: remove method? confusing design
+       public static function getRootLogger() {
                return LoggerManager::getRootLogger();    
        }
 
@@ -405,8 +396,7 @@
        }
 
        /**
-        * Only the Hierarchy class can set the hierarchy of a
-        * category.
+        * Only the Hierarchy class can set the hierarchy of a category.
         *
         * @param LoggerHierarchy $repository
         */
@@ -427,7 +417,7 @@
         * Sets the parent logger of this logger
         */
        public function setParent(Logger $logger) {
-                       $this->parent = $logger;
+               $this->parent = $logger;
        } 
 
        /**
@@ -445,5 +435,4 @@
                        $this->forcedLog($this->fqcn, $caller, $warnLevel, 
$message);
                }
        }
-
 }