Author: grobmeier
Date: Sat May 23 17:07:11 2009
New Revision: 777964
URL: http://svn.apache.org/viewvc?rev=777964&view=rev
Log:
completed null appender test - no assertions
Modified:
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderNull.php
incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderNullTest.php
Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderNull.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderNull.php?rev=777964&r1=777963&r2=777964&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderNull.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderNull.php Sat
May 23 17:07:11 2009
@@ -1,5 +1,5 @@
<?php
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -31,6 +31,10 @@
protected $requiresLayout = false;
+ public function __construct($name) {
+ parent::__construct($name);
+ }
+
public function activateOptions() {
$this->closed = false;
}
@@ -41,11 +45,10 @@
/**
* Do nothing.
- * How I Love it !! :)
- *
+ *
* @param LoggerLoggingEvent $event
*/
- protected function append($event) {
+ public function append($event) {
}
}
Modified:
incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderNullTest.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderNullTest.php?rev=777964&r1=777963&r2=777964&view=diff
==============================================================================
--- incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderNullTest.php
(original)
+++ incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderNullTest.php
Sat May 23 17:07:11 2009
@@ -24,13 +24,14 @@
*/
class LoggerAppenderNullTest extends PHPUnit_Framework_TestCase {
-
+ /**
+ * The Null appender does nothing - nothing to assert.
+ * Just here for the sake of completness and a good testing ratio :-)
+ */
public function testActivateOptions() {
- self::markTestIncomplete();
- }
-
- public function testClose() {
- self::markTestIncomplete();
+ $appender = new LoggerAppenderNull("TEST");
+ $appender->activateOptions();
+ $appender->append(null);
+ $appender->close();
}
-
}
