[ 
https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859662#action_12859662
 ] 

Christian Grobmeier commented on LOG4PHP-109:
---------------------------------------------

Hello,,

this patch is great but:

- i had to remove BSD license in favour to Apache License
- i removed some doc tags, like @author. On this project we agreed not to use it

Is this acceptable for you? If yes, then read on because
my LoggerRendererExceptionTest::testRender function fails on a Mac

You check the lenght here which should be 3986 but mine is 3837

Any ideas why? Probably an operating system issue

Cheers

> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
>                 Key: LOG4PHP-109
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-109
>             Project: Log4php
>          Issue Type: New Feature
>          Components: Code, Documentation, Tests
>    Affects Versions: 2.2, 2.3
>         Environment: PHP
>            Reporter: Vladimir Gorej
>         Attachments: throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. 
> With this patch applied it will be possible to log exceptions and nested 
> exceptions with their full stack traces

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to