[ 
https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859704#action_12859704
 ] 

Vladimir Gorej commented on LOG4PHP-109:
----------------------------------------

Hi Christian,

> - i had to remove BSD license in favour to Apache License 
Of course, I have no problem with that

> - - i removed some doc tags, like @author. On this project we agreed not to 
> use it 
No problem with that either, but since there is nothing else to link me to this 
patch,
do I get it to the contributors list ? :)

I will dive into LoggerRendererExceptionTest::testRender tonight. It is 
definitely OS issue.
In patch I am using platform dependent PHP_EOL. I will attach corrected patch 
in a couple
of days.

I am glad that this patch will get into log4php. Thanks

> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
>                 Key: LOG4PHP-109
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-109
>             Project: Log4php
>          Issue Type: New Feature
>          Components: Code, Documentation, Tests
>    Affects Versions: 2.2, 2.3
>         Environment: PHP
>            Reporter: Vladimir Gorej
>         Attachments: throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. 
> With this patch applied it will be possible to log exceptions and nested 
> exceptions with their full stack traces

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to