And we add yet ANOTHER broken implementation.  This brings up
my total to 39,  and no you cannot have the names,  some
are embarrased and asked me not to tell who they are.
Right James? But we know who you are ... :-)

I will add the patch... sigh...

>From [EMAIL PROTECTED] Sun Jan  7 08:10:55 2001
Date: Mon, 08 Jan 2001 02:10:43 +1000
From: Darius Davis <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: Apple Desktop Printing bug fix

This is a multi-part message in MIME format.
--------------E5631EE9E262E9A16A2C4ABA
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi Patrick,

Thanks many times over for your work on LPRng.  We're using it at King's
College at the University of Queensland (Australia) and - although we
still have occasional glitches - the software is performing quite well.

The biggest problem we've encountered is actually a bug in the Apple
Desktop Printing system which causes data to be sporadically re-sent to
the LPR server when it's not expecting it.  This occurs every 100 or so
jobs, on the average, and causes the print job submission to fail with
this error message on the client Macintosh:

---------------------------------------------------------------------
The document could not be printed.  The LPR printer you are
attempting to print to cannot accept jobs. Please check that the printer
is not turned off or busy.

-8873
---------------------------------------------------------------------

Apple haven't really been all too cooperative in resolving the problem,
so I came up with a server-side fix which reduces the problem to almost
nil.

My fix simply determines when that type of invalid request arrives, and
if so it simply ignores the duplicated data.  Valid LPR requests should
be completely unaffected by the patch, only the handling of invalid
requests is modified.  Given that I'm probably not the only person in
the world with this problem, I figured I'd send you the fix for
inclusion in the LPRng code, if you think it's appropriate (after all,
the bug isn't in your code).

For all the gory details of the bug, take a look at

http://www.kings.uq.edu.au/lprbug.html

which is a series of emails I sent to an Apple rep in an attempt to get
the problem fixed.

The 'stuttered' data is almost always the packet specifying the print
queue, but very rarely (perhaps one in every few hundred malformed
requests) other packets are stuttered and the client will still produce
an error.  At my site, this patch has reduced the complaint-call rate
from 2 or 3 a day to practically none.

Anyway, if you can use this code (not that it's anything earth-
shattering), then that's cool, if you don't think a fix for an Apple bug
belongs in LPRng then that's cool too, I can continue to merge the code
in on my own when I update LPRng.

The attachment is a diff against "LPRng-3.7.4/src/common/lpd_rcvjob.c". 
The patch has had extensive testing with LPRng-3.6.12, and only minimal
testing with LPRng-3.7.4, although I can't see any places where it's
likely to break anything.

Cheers,

Darius
-- 
Darius Davis   Evolution of      What You See Is What You Get: WYSIWYG
s328919 at     modern         What You See Is What You Desire: WYSIWYD
student.uq.    computer     What You See Is Not Your Document: WYSINYD
edu.au         software         Now You See It, Now You Don't: NYSINYD
--------------E5631EE9E262E9A16A2C4ABA
Content-Type: text/plain; charset=us-ascii; name="AppleLPRfix.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="AppleLPRfix.txt"

--- lpd_rcvjob.c        Thu Dec 28 23:06:05 2000
+++ my-lpd_rcvjob.c     Mon Jan  8 01:06:12 2001
@@ -225,6 +225,14 @@
                /* make sure we have length and filename */
                filename = 0;
                file_len = strtod(line+1,&filename);
+               if ((line+1) == filename){
+                       /* Recover from Apple Desktop Printing stupidity.
+                          It occasionally resends the queue selection cmd.
+                          DD 03JUL2000 */
+                       status = 0;
+                       logerr(LOG_ERR, "Recovering from incorrect job submission");
+                       continue;
+               }
                if( filename ){
                        while( isspace(cval(filename)) ) ++filename;
                        Clean_meta(filename);


--------------E5631EE9E262E9A16A2C4ABA--



-----------------------------------------------------------------------------
YOU MUST BE A LIST MEMBER IN ORDER TO POST TO THE LPRNG MAILING LIST
The address you post from MUST be your subscription address

If you need help, send email to [EMAIL PROTECTED] (or lprng-requests
or lprng-digest-requests) with the word 'help' in the body.  For the impatient,
to subscribe to a list with name LIST,  send mail to [EMAIL PROTECTED]
with:                           | example:
subscribe LIST <mailaddr>       |  subscribe lprng-digest [EMAIL PROTECTED]
unsubscribe LIST <mailaddr>     |  unsubscribe lprng [EMAIL PROTECTED]

If you have major problems,  send email to [EMAIL PROTECTED] with the word
LPRNGLIST in the SUBJECT line.
-----------------------------------------------------------------------------

Reply via email to