Hi Tom, 

I believe Yingzhen and I have fixed all of these nits in the -14 version. 

https://datatracker.ietf.org/doc/draft-ietf-lsr-ospfv3-extended-lsa-yang/


> On Jun 1, 2023, at 6:16 AM, tom petch <ie...@btconnect.com> wrote:
> 
> Acee
> 
> My comments all relate to the 'latter I-D', that is to the extended LSAs YANG 
> model, the one you really want to publish and not to the admin tags (which 
> you will doubtless want to publish in due course).
> 
> Tom Petch.
> _____________________________________
> From: Acee Lindem <acee.i...@gmail.com>
> Sent: 31 May 2023 19:44
> Subject: Re: [Lsr] I-D Action: draft-ietf-lsr-ospf-admin-tags-08.txt
> 
> Hi Tom,
> 
> On May 31, 2023, at 06:45, tom petch <ie...@btconnect.com> wrote:
> 
> From: Lsr <lsr-boun...@ietf.org<mailto:lsr-boun...@ietf.org>> on behalf of 
> Acee Lindem <acee.i...@gmail.com<mailto:acee.i...@gmail.com>>
> Sent: 28 May 2023 20:35
> 
> Simply refreshed before expiration and updated a reference. We really need to 
> publish the extended LSAs YANG model as it is a prerequisite for a lot of 
> drafts.
> 
> <tp>
> Regarding the latter, I noted back in 2020 that it was a tough read and that 
> has not changed, so I will likely only have the energy to review it once and 
> so will wait for at least WGLC before undertaking such a review.  Meanwhile  
> I see some editorial glitches but would not appreciate a revised I-D unless 
> and until that WGLC is imminent.
> 
> s.1.1 text is out of date
> 
> I don’t see a problem in -09.

I updated with with the full list of normative words. 


> 
> 
> /opf:ospfv3/ospf:body:
> here and elsewhere, what is the final colon doing?
> 
> I don’t see this anywhere in the draft.

For better or worse, this is the format that “pyang -f tree” provides. 


> 
> 
> 
> contact URL is out of date
> 
> I’ll update my Email.

This is updated. 


> 
> 
> references to OSPF YANG need updating to the RFC
> 
> This is fixed in -09.

Fixed. 


> 
> 
> 
> 'Figure .. ' now appears in four places, doubtless a 'good idea' from the 
> tool makers.
> 
> There is only “Figure 1”.

I agree this is confusing. I’ve removed all the figure designations.  

Thanks,
Acee



> 
> Thanks,
> Acee
> 
> 
> 
> Like I say, not justifying a new I-D just yet IMHO.
> 
> Tom Petch
> 
> Thanks,
> Acee
> 
> On May 28, 2023, at 3:29 PM, internet-dra...@ietf.org wrote:
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories. This Internet-Draft is a work item of the Link State Routing
> (LSR) WG of the IETF.
> 
> Title           : Extensions to OSPF for Advertising Prefix Administrative 
> Tags
> Authors         : Acee Lindem
>                   Peter Psenak
>                   Yingzhen Qu
> Filename        : draft-ietf-lsr-ospf-admin-tags-08.txt
> Pages           : 19
> Date            : 2023-05-28
> 
> Abstract:
> It is useful for routers in OSPFv2 and OSPFv3 routing domains to be
> able to associate tags with prefixes.  Previously, OSPFv2 and OSPFv3
> were relegated to a single tag and only for AS External and Not-So-
> Stubby-Area (NSSA) prefixes.  With the flexible encodings provided by
> OSPFv2 Prefix/Link Attribute Advertisement and OSPFv3 Extended LSAs,
> multiple administrative tags may be advertised for all types of
> prefixes.  These administrative tags can be used for many
> applications including route redistribution policy, selective prefix
> prioritization, selective IP Fast-ReRoute (IPFRR) prefix protection,
> and many others.
> 
> The ISIS protocol supports a similar mechanism that is described in
> RFC 5130.
> 
> The IETF datatracker status page for this Internet-Draft is:
> https://datatracker.ietf.org/doc/draft-ietf-lsr-ospf-admin-tags/
> 
> There is also an HTML version available at:
> https://www.ietf.org/archive/id/draft-ietf-lsr-ospf-admin-tags-08.html
> 
> A diff from the previous version is available at:
> https://author-tools.ietf.org/iddiff?url2=draft-ietf-lsr-ospf-admin-tags-08
> 
> Internet-Drafts are also available by rsync at rsync.ietf.org::internet-drafts
> 
> 
> _______________________________________________
> Lsr mailing list
> Lsr@ietf.org
> https://www.ietf.org/mailman/listinfo/lsr
> 
> _______________________________________________
> Lsr mailing list
> Lsr@ietf.org<mailto:Lsr@ietf.org>
> https://www.ietf.org/mailman/listinfo/lsr
> 

_______________________________________________
Lsr mailing list
Lsr@ietf.org
https://www.ietf.org/mailman/listinfo/lsr

Reply via email to