> fadvise cases should check TEST_ERRNO instead of TEST_RETURN.

Do you mean man page is incorrect?

man fadvise:
    POSIX_FADVISE(2)           Linux Programmer’s Manual          
POSIX_FADVISE(2)
    ...
    RETURN VALUE
           On success, zero is returned.  On error, an error number is returned.
----------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^


glibc/sysdeps/unix/sysv/linux/i386/posix_fadvise64.S:
#ifdef __NR_fadvise64_64

        /* Save registers.  */
        pushl   %ebp
        cfi_adjust_cfa_offset (4)
        pushl   %ebx
        cfi_adjust_cfa_offset (4)
        pushl   %esi
        cfi_adjust_cfa_offset (4)
        pushl   %edi
        cfi_adjust_cfa_offset (4)

        movl    FD(%esp), %ebx
        cfi_rel_offset (ebx, 8)
        movl    OFFLO(%esp), %ecx
        movl    OFFHI(%esp), %edx
        movl    LENLO(%esp), %esi
        cfi_rel_offset (esi, 4)
        movl    LENHI(%esp), %edi
        cfi_rel_offset (edi, 0)
        movl    FLAGS(%esp), %ebp
        cfi_rel_offset (ebp, 12)

        movl    $SYS_ify(fadvise64_64), %eax
        ENTER_KERNEL

        /* Restore registers.  */
        popl    %edi
        cfi_adjust_cfa_offset (-4)
        cfi_restore (edi)
        popl    %esi
        cfi_adjust_cfa_offset (-4)
        cfi_restore (esi)
        popl    %ebx
        cfi_adjust_cfa_offset (-4)
        cfi_restore (ebx)
        popl    %ebp
        cfi_adjust_cfa_offset (-4)
        cfi_restore (ebp)

#ifndef __ASSUME_FADVISE64_64_SYSCALL
        cmpl    $-ENOSYS, %eax
        je      1f
#endif

        /* The function returns zero, or the error number.  So all we
           have to do is negate the value passed back from the kernel.  */
        /* If 0 > %eax > -4096 there was an error.  */
------> negl    %eax
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to