On Tuesday 10 February 2009 00:07:33 Masatake YAMATO wrote:
> > fadvise cases should check TEST_ERRNO instead of TEST_RETURN.
>
> Do you mean man page is incorrect?
>
> man fadvise:
>     POSIX_FADVISE(2)           Linux Programmer’s Manual         
> POSIX_FADVISE(2) ...
>     RETURN VALUE
>          On success, zero is returned.  On error, an error number is returned.
> ----------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^
>^^^^

looks like the uClibc implementation might be wrong ... we'll have to check it 
out

>       movl    $SYS_ify(fadvise64_64), %eax
>       ENTER_KERNEL
>
>       ....
>
> #ifndef __ASSUME_FADVISE64_64_SYSCALL
>       cmpl    $-ENOSYS, %eax
>       je      1f
> #endif
>
>       /* The function returns zero, or the error number.  So all we
>          have to do is negate the value passed back from the kernel.  */
>       /* If 0 > %eax > -4096 there was an error.  */
> ------>       negl    %eax

thanks for highlighting this
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to