On Wed, 2010-01-13 at 14:49 -0800, Garrett Cooper wrote: > On Wed, Jan 13, 2010 at 2:03 PM, Stephen Smalley <[email protected]> wrote: > > On Wed, 2010-01-13 at 16:00 -0600, Serge E. Hallyn wrote: > >> Quoting Stephen Smalley ([email protected]): > >> > On Wed, 2010-01-13 at 11:37 -0800, Garrett Cooper wrote: > >> > > Yeah, you're right. I was trying to beat around this bush by not > >> > > copying these over, but it's better to have the test running and be > >> > > improperly designed than it is for regressions to leak by today, until > >> > > the day comes where these items are fixed. > >> > > > >> > > 1. So, Makefile is now copied over by default. > >> > > 2. load is no longer done as part of all / install (test_selinux.sh > >> > > was performing that function). > >> > > > >> > > So once the tests have been written to make and install independent of > >> > > selinux-devel, etc... we'll be in good shape and I will switch these > >> > > back to all / install dependent targets. I was trying to do it that > >> > > way to avoid requiring make on the target under test, but I need to > >> > > better understand the subject matter under test before we get to that > >> > > point. > >> > > >> > Unfortunately, as the Makefile now includes other .mk files and those > >> > are not copied over, it still doesn't work. > >> > > >> > Makefile:25: ../../../../../include/mk/env_pre.mk: No such file or > >> > directory > >> > make: ../../../../../scripts/detect_distro.sh: Command not found > >> > Makefile:90: ../../../../../include/mk/generic_leaf_target.mk: No such > >> > file or directory > >> > make: *** No rule to make target > >> > `../../../../../include/mk/generic_leaf_target.mk'. Stop. > >> > Failed to build and load test_policy module, aborting test run. > >> > /etc/selinux > >> > /opt/ltp/testcases/kernel/security/selinux-testsuite/refpolicy > >> > /opt/ltp/testcases/kernel/security/selinux-testsuite/refpolicy > >> > > >> > I suppose you could perform the make load as part of all/install > >> > (preferably install as we really shouldn't need to be root to run make > >> > all - although that no longer seems to be the case for the main ltp > >> > either), and drop it from test_selinux.sh. But then they will need to > >> > know/remember to remove the test policy when finished testing. > >> > >> But really the compile stage should just create test_policy.pp, > >> which the testsuite can load and unload, right? > > > > Yes, that should work. > > Which is what it's doing now, but the original author of the test > wrote the load logic and unload logic so that it used make instead of > using a bourne shell script, etc.
To clarify, there are two things happening under that load target presently, one of which is properly handled at build time and one of which is properly handled at test execution time. The first part is building test_policy.pp. The latter is running semodule -i test_policy.pp. So we could split up the Makefile so that the first part is done by the make all/install, and test_selinux.sh merely runs semodule -i test_policy.pp before the test and semodule -r test_policy after the test. One other item I notice is that the current logic copies test_policy* to $POLICY_DEVEL_DIR and runs make there, which isn't necessary - you could just leave them in the refpolicy directory and run make -f $POLICY_DEVEL_DIR/Makefile test_policy.pp. > The other thing that's kind of amusing is that its setup / teardown > isn't very robust -- I could send a signal, or the process could get > terminated leaving the test policy files hanging around the system > under test. That's a side issue but it's also another good reason to > migrate away from this make paradigm for setup / teardown -_-... -- Stephen Smalley National Security Agency ------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
