> -----Original Message----- > From: Garrett Cooper [mailto:[email protected]] > Sent: Wednesday, April 14, 2010 6:31 PM > To: Mitani > Cc: [email protected] > Subject: Re: [LTP] [PATCH] fix "hugetlb" several tests > > On Wed, Apr 14, 2010 at 1:58 AM, Mitani <[email protected]> wrote: > >> -----Original Message----- > >> From: Garrett Cooper [mailto:[email protected]] > >> Sent: Wednesday, April 14, 2010 3:18 PM > >> To: Mitani > >> Cc: Randy Dunlap; [email protected] > >> Subject: Re: [LTP] [PATCH] fix "hugetlb" several tests > >> > >> On Tue, Apr 13, 2010 at 7:17 PM, Mitani <[email protected]> wrote: > >> > Hi Randy, > >> > > >> > I couldn't notice a misspelling. Sorry. > >> > I decided to use "due to" according to your advice. > >> > > >> > May I suggest revised patch? > >> > > > [...] > >> > > >> > Thank you-- > >> > > >> > -Tomonori Mitani > >> > > >> > > >> >> -----Original Message----- > >> >> From: Randy Dunlap [mailto:[email protected]] > >> >> Sent: Wednesday, April 14, 2010 12:04 AM > >> >> To: Mitani > >> >> Cc: [email protected] > >> >> Subject: Re: [LTP] [PATCH] fix "hugetlb" several tests > >> >> > >> >> On 04/12/10 23:58, Mitani wrote: > >> >> > ------------ > >> >> > a) All tests: > >> >> > "TBROK : Test cannot be continued owning to sufficient > >> >> availability of > >> >> > Hugepages on the system" > >> >> > > >> >> > b) 2), 3), 5), 6), 8), 10), 11) tests: > >> >> > "TWARN : tst_rmdir(): TESTDIR was NULL; no removal > attempted" > >> >> > ------------ > >> >> > > >> >> > Both case a) and case b) are caused by the same reason. > >> >> > > >> >> > All of case a) failures occured at the following points (for > >> example > >> >> > hugemmap04): > >> >> > ------------<hugemmap04.c - main()> > >> >> > /* Check number of hugepages */ > >> >> > if (get_no_of_hugepages() <= 0 || hugepages_size() > <= > >> 0) > >> >> > tst_brkm(TBROK, cleanup, "Test cannot be > >> continued > >> >> owning to > >> >> > \ > >> >> > sufficient availability > of > >> >> Hugepages on the > >> >> > system"); > >> >> > ------------ > >> >> > > >> >> > I found out that "HugePages_Total" parameter of "/proc/meminfo" > >> file > >> >> > is set to "0". This caused above TBROK failure. It is environment > >> >> problem. > >> >> > > >> >> > But, in this case, tests must not return with TBROK, but with > TCONF, > >> >> > I think. > >> >> > >> >> That makes sense to me. > >> >> > >> >> > And, in case b), these tests try to delete "TESTDIR" directory > >> by > >> >> > calling "tst_rmdir()" function in "cleanup()" function. > >> >> > But, "TESTDIR" never set if "tst_tmpdir()" function isn't > called. > >> >> > I think that case b)'s tests must not call cleanup() function. > >> >> > > >> >> > > >> >> > I want to suggest following patch. > >> >> > > >> >> > Signed-off-by: Tomonori Mitani <[email protected]> > > Sorry to ask again, but Gmail always mangles patches. Could you > please attach it as a file? > Thanks, > -Garrett
Sorry. I attach a patch file. Signed-off-by: Tomonori Mitani <[email protected]> Regards-- -Tomonori Mitani
hugetlb.patch
Description: Binary data
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
