On Fri, Jul 23, 2010 at 10:17 AM, Nicolas Joly <[email protected]> wrote: > > Hi, > > The attached patch do some cleanup in the abort01 testcase ... > > 1) The attempt to remove the generated core is wrong. The hard-coded > `core' name is bad and the test temporary directory removal already > take care of this. > > 2) Make the test fail gracefully if the running environment does not > allow generating core files. > > nj...@lanfeust [syscalls/abort]> ./abort01 > abort01 1 TPASS : Test passed > nj...@lanfeust [syscalls/abort]> (ulimit -c 0 && ./abort01) > abort01 1 TCONF : core file size limit must be greater than 0. > > Signed-off-by: Nicolas Joly <[email protected]>
Looks ok, but is there any particular reason why you removed the unlink(2) call? Thanks, -Garrett ------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
