On Tue, Sep 28, 2010 at 9:40 PM, Mitani <[email protected]> wrote:
>> -----Original Message-----
>> From: Garrett Cooper [mailto:[email protected]]
>> Sent: Tuesday, September 07, 2010 4:04 PM
>> To: Mitani
>> Cc: [email protected]
>> Subject: Re: [LTP] About "hugeshmat01" and "humeshmget03" testsets
>>
>> On Mon, Sep 6, 2010 at 11:53 PM, Mitani <[email protected]> wrote:
>> > Hi,
>> >
>> > I sent patches of "hugeshmat01" and "humeshmget03" testsets to
>> mailing-list
>> > in the middle of August, but they aren't updated.
>> > Would you teach me what kind of situation they are?
>> >
>> >  hugeshmat01:
>> >    http://www.mail-archive.com/[email protected]/m
>> sg10448.html
>> >  humeshmget03:
>> >    http://www.mail-archive.com/[email protected]/m
>> sg10467.html
>> >
>> >  (The "humeshmat01" was revised on August 16, but same failure has
>> >   occurred in my system.)
>> >
>> > I am glad if I can get some information about the patch.
>> > I'm looking forward to reply:-)
>>
>>     Sorry... another item I forgot to follow up on. I'll look into
>> this over the next couple of days and provide feedback about this.
>> Thanks,
>> -Garrett
>
> Were my revisions OK?
> I am glad if you consider about these patches when you are free.

1. Where's the requirement noted that you added the code for in hugeshmget03 ?
2. How do you know the value added to hugeshmat01 isn't page aligned?
Why not get the page size from sysconf and subtract the value from
one, and add _that_ value?

Thanks,
-Garrett

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to