> -----Original Message----- > From: Garrett Cooper [mailto:yaneg...@gmail.com] > Sent: Sunday, October 03, 2010 10:02 AM > To: Mitani > Cc: ltp-list@lists.sourceforge.net > Subject: Re: [LTP] About "hugeshmat01" and "humeshmget03" testsets > > On Tue, Sep 28, 2010 at 9:40 PM, Mitani <mit...@ryobi.co.jp> wrote: > >> -----Original Message----- > >> From: Garrett Cooper [mailto:yaneg...@gmail.com] > >> Sent: Tuesday, September 07, 2010 4:04 PM > >> To: Mitani > >> Cc: ltp-list@lists.sourceforge.net > >> Subject: Re: [LTP] About "hugeshmat01" and "humeshmget03" testsets > >> > >> On Mon, Sep 6, 2010 at 11:53 PM, Mitani <mit...@ryobi.co.jp> wrote: > >> > Hi, > >> > > >> > I sent patches of "hugeshmat01" and "humeshmget03" testsets to > >> mailing-list > >> > in the middle of August, but they aren't updated. > >> > Would you teach me what kind of situation they are? > >> > > >> > hugeshmat01: > >> > > http://www.mail-archive.com/ltp-list@lists.sourceforge.net/m > >> sg10448.html > >> > humeshmget03: > >> > > http://www.mail-archive.com/ltp-list@lists.sourceforge.net/m > >> sg10467.html > >> > > >> > (The "humeshmat01" was revised on August 16, but same failure > has > >> > occurred in my system.) > >> > > >> > I am glad if I can get some information about the patch. > >> > I'm looking forward to reply:-) > >> > >> Sorry... another item I forgot to follow up on. I'll look into > >> this over the next couple of days and provide feedback about this. > >> Thanks, > >> -Garrett > > > > Were my revisions OK? > > I am glad if you consider about these patches when you are free. > > 1. Where's the requirement noted that you added the code for in > hugeshmget03 ? > 2. How do you know the value added to hugeshmat01 isn't page aligned? > Why not get the page size from sysconf and subtract the value from > one, and add _that_ value? > > Thanks, > -Garrett
>1. Where's the requirement noted that you added the code for in hugeshmget03 ? It is in follwing URL in August 13: http://www.mail-archive.com/ltp-list@lists.sourceforge.net/msg10467.html >2. How do you know the value added to hugeshmat01 isn't page aligned? It is in follwing URL in August 09: http://www.mail-archive.com/ltp-list@lists.sourceforge.net/msg10448.html http://www.mail-archive.com/ltp-list@lists.sourceforge.net/msg10532.html The reason that hugeshmat01 isn't page aligned is from the shmat()'s error code 22 (EINVAL). shmat()'s man page says about this error code: ------------ EINVAL The value of shmid is not a valid shared memory identifier, the shmaddr is not a null pointer, and the value of (shmaddr -((uintptr_t)shmaddr %SHMLBA)) is an illegal address for attaching shared memory; or the shmaddr is not a null pointer, (shmflg &SHM_RND) is 0, and the value of shmaddr is an illegal address for attaching shared memory. ------------ The failure occurred in following shmat(): ---(hugeshmat01.c)--------- [...] for (i=0; i<TST_TOTAL; i++) { /* * Use TEST macro to make the call */ errno = 0; addr = shmat(*(TC[i].shmid), (void *)(TC[i].addr), TC[i].flags); [...] ------------ This failure occurred in second loop (i=1), and arguments of shmat() are as follows: ------------ shmat(id, 0x10000000eee, SHM_RND) ------------ "shmaddr" argument (second argument) of shmat() is not NULL. Therefore I thought that page aligned occurred. >Why not get the page size from sysconf and subtract the value from one, and add _that_ value? This value is dynamic address, and this is the value which the first shmat() returned. This is the value with achievement in the each users system at least. When a fixed address ("0x10000000eee" or "0x60000eee") was specified, depending on a case, this address may be the address which other processes use. I thought that this method of using dynamic address is better than using fixed value to "shmaddr" argument. Thank you-- -Tomonori Mitani ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
