Hi! > > I've added missing return stream; here and pushed both patches, > > thanks. > > Whoa, did I really miss that? Wondering how my test could have > run... Must have used the wrong version of the code when testing or > something.
I've seen cases where such code was running fine because the register used to return function value was the same that was allocated for the temporary variable... > But thanks for the merge! > > Now you know why I really liked forcing people into using > -Werror ;-) Could it be a good idea to actually use -Werror by default, > and having a "production" flag for those who don't want it? Just to > ensure that lazy people are those being best looked after... I would be for reversing the logic, i.e. adding developer flag that enables -Werror. Unfortunatelly LTP has tons of legacy code that produces megatons of warnings and fixing all of these would be a big effort. -- Cyril Hrubis [email protected] ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
