On Tue, 13 May 2014 14:02:36 +0200 <[email protected]> wrote: > > Hmm, but a compromise could be this: > > > > Let's say we have a "production flag" which then each module could > > make their mind up whether it should have any effect or not. If it > > should have an effect, then the effect should be to disable -Werror. > > I'm still not convinced that enabling -Werror by default is a good > idea. Compiler warnings are quite unstable among different versions > and code that produces no warnings with one version is not guaranteed > not to produce anything with another, and there are false positives > too. > > Cloning LTP from git, running configure and make must not fail just > because you have different compiler version than developers. > > > This way, you can fix warnings on one module at a time, no big bang > > change. When a module is fixed, you change it to use -Werror unless > > this "production flag" is used. > > That sounds to me as too much work for not so much gain. > > I guess that we can add a configure parameter that adds a variable > into config.mk something as WERROR which gets set to -Werror only if > it's supported by compiler and enabled by user. Then we can do > CFLAGS+=$(WERROR) in a few Makefiles. >
My experience is that if you do not force -Werror on developers, warnings will live and prosper. I don't think we'll ever reach zero warnings on all compiles without it. And reaching zero warnings is something I think is important for something that is supposed to prove correctness of code. But this is of course only my humble opinion. Regards Mats Liljegren ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
