Hi!
> ext4-persist-prealloc test will call test cases under 
> 'testcases/kernel/syscalls
> /fallocate' to have persist prealloc test for ext4 filesystem. But currently
> fallocate[0-3] cases will have tests in a different filesystem, which the 
> directory
> created by tst_tmpdir() is in. This is wrong, fix it.
> 
> Signed-off-by: Xiaoguang Wang <[email protected]>
> ---
>  .../ext4-persist-prealloc/ext4_persist_prealloc_test.sh                | 3 
> +++
>  1 file changed, 3 insertions(+)
> 
> diff --git 
> a/testcases/kernel/fs/ext4-new-features/ext4-persist-prealloc/ext4_persist_prealloc_test.sh
>  
> b/testcases/kernel/fs/ext4-new-features/ext4-persist-prealloc/ext4_persist_prealloc_test.sh
> index 20b66f8..063a701 100755
> --- 
> a/testcases/kernel/fs/ext4-new-features/ext4-persist-prealloc/ext4_persist_prealloc_test.sh
> +++ 
> b/testcases/kernel/fs/ext4-new-features/ext4-persist-prealloc/ext4_persist_prealloc_test.sh
> @@ -46,6 +46,8 @@ ext4_test_persist_prealloc()
>  
>       ret=1
>  
> +     temp_tmpdir=$TMPDIR
> +     export TMPDIR=mnt_point
>       for ((i = 1; i <= 3; i++))
>       {
>               if ! command -v fallocate0${i} > /dev/null 2>&1; then
> @@ -63,6 +65,7 @@ ext4_test_persist_prealloc()
>                       return
>               fi
>       }
> +     TMPDIR=$temp_tmpdir


Can't we just do:

TMPDIR=mnt_point; fallocate0${i}

instead?

-- 
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to