Hi, On 06/24/2014 12:18 AM, [email protected] wrote: > Hi! >>>> ret=1 >>>> >>>> + temp_tmpdir=$TMPDIR >>>> + export TMPDIR=mnt_point >>>> for ((i = 1; i <= 3; i++)) >>>> { >>>> if ! command -v fallocate0${i} > /dev/null 2>&1; then >>>> @@ -63,6 +65,7 @@ ext4_test_persist_prealloc() >>>> return >>>> fi >>>> } >>>> + TMPDIR=$temp_tmpdir >>> >>> >>> Can't we just do: >>> >>> TMPDIR=mnt_point; fallocate0${i} >>> >>> instead? >> >> Yeah, we can do it, but this will make TMPDIR still be "mnt_point" after the >> fallocate tests. > > That is the point of it. As it is you are saving and restoring the > TMPDIR before and after the loop so redefining it only for the part that > matters looks cleaner to me or did I overlooked something?
Hmm, I guess I have understood your explanation :) New version will be sent soon, thanks. Regards, Xiaoguang Wang > ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
