On 30 March 2013 00:23, Gary V. Vaughan <[email protected]> wrote:
> Hi Hisham,
>
> On 30 Mar 2013, at 05:56, Hisham <[email protected]> wrote:
>
>> On 29 March 2013 02:34, Gary V. Vaughan <[email protected]> wrote:
>>> Rockspec for stdlib version 34-2 attached.
>>
>> I noticed the rockspec is identical, apart from the revision number.
>> Did you move the "release-34" tag in git? (That's not considered good
>> practice, AFAIK).
>
> I hope not, it should have picked up release-34-2, so there's an error in
> The rockspec I posted. thanks for pointing it out!
>
>> The "-2" suffix in a rockspec refers to the rockspec revision only,
>> not to the version of the actual project. If there were any changes in
>> your code, please pack it as a new numbered version, either as 35 or
>> 34.2, and then release it as 35-1 or 34.2-1.
>
> The idea was that we corrected an error in stdlib-34, and wanted to supersede
> that broken release. I'll fix the rockspec in the fixed release and repost.
>
>> If you're decided on calling your version number "34-2", then
>> unfortunately that numbering is incompatible with LuaRocks, and we'll
>> have to rename it to something like "34.2" in order to use "34.2-1"
>> for the full version-revision string. The reason for that is because
>> we support hyphens in package names, so "stdlib-34-2-1.rockspec" would
>> be ambiguous: it currently parses as "stdlib-34" version "2", revision
>> "1".
>
> How about calling it 34a, which is the usual GNU project method of repackaging
> A broken previous release?
>
> if not, then 34.1-1 seems like a decent compromise.
Either 34a or 34.1 will be correctly interpreted by LuaRocks as being
more than 34 and less than 35.
34 < 34a < 34.1 < 35
Lua 5.2.0 Copyright (C) 1994-2011 Lua.org, PUC-Rio
> deps = require "luarocks.deps"
> v34a = deps.parse_version("34a")
> v34_1 = deps.parse_version("34.1")
> v34 = deps.parse_version("34")
> v35 = deps.parse_version("35")
> print (v34 < v35)
true
> print (v35 < v34)
false
> print (v34a > v34)
true
> print (v34_1 > v34a)
true
> print (v34a > v34_1)
false
> print (v34 < v34a)
true
> print (v34a < v35)
true
So, it's your pick.
> Either way, is it possible to pull the previous stdlib-34-1 from the repo to
> prevent
> giving the broken version to anyone else?
We don't usually remove old rocks from the repo since third-party
repos may depend on them (and to preserve a sense of history), but
since this is the latest available release (ie, the one people pick up
with `luarocks install stdlib`), I'll take it down at least until the
new version comes up.
-- Hisham
http://hisham.hm/
------------------------------------------------------------------------------
Own the Future-Intel(R) Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest. Compete
for recognition, cash, and the chance to get your game on Steam.
$5K grand prize plus 10 genre and skill prizes. Submit your demo
by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
_______________________________________________
Luarocks-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/luarocks-developers
