[
https://issues.apache.org/jira/browse/LUCENENET-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775009#action_12775009
]
George Aroush commented on LUCENENET-210:
-----------------------------------------
Now that I know which test this is trying to address, I want to study it
further, but here is some early comments.
I agree that the use of DirectoryInfo over FileInfo is more appropriate. It's
a tradeoff between automation vs. manual port. However, if we do so now, we
are breaking any code that depends on those methods (this includes the demo
code which you need to supply a patch for it too, otherwise this patch will
break it).
My suggestion is we add new methods that take DirectoryInfo and depreciate
those that take FileInfo. We can remove the depreciated methods with 3.0.
> FSDirectory - DirectoryInfo vs. FileInfo
> ----------------------------------------
>
> Key: LUCENENET-210
> URL: https://issues.apache.org/jira/browse/LUCENENET-210
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Michael Garski
> Attachments: FSDirectory_di_vs_fi.patch
>
>
> From what I know of the Java File class, it can represent a file or a
> directory, whereas in .NET the explicit classes FileInfo and DirectoryInfo
> would apply. I've altered the usage of the two different classes depending
> on what the purpose is, be it a directory or a file. This does change the
> interface to instantiation of classes such as IndexReader with a
> DirectoryInfo object as opposed to a FileInfo object which is more precise
> and actually cleans up the internals a bit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
