[ 
https://issues.apache.org/jira/browse/LUCENENET-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776279#action_12776279
 ] 

George Aroush commented on LUCENENET-210:
-----------------------------------------

I'm still not sure what's the best approach to address Mike's point #3.  Should 
we just change it to return DirectoryInfo (with 2.9 release) and move on?  I'm 
not comfortable with the addition of a new API as it won't be consistent with 
Java Lucene.

This API is public (in Java Lucene too) but is not documented, so I'm guessing 
it's not really used externally.

If there is no objection, I'm ready to commit this patch by having 
FSDirectory.GetFile() return DirectoryInfo.

> FSDirectory - DirectoryInfo vs. FileInfo
> ----------------------------------------
>
>                 Key: LUCENENET-210
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-210
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Michael Garski
>         Attachments: FSDirectory V2.patch
>
>
> From what I know of the Java File class, it can represent a file or a 
> directory, whereas in .NET the explicit classes FileInfo and DirectoryInfo 
> would apply.  I've altered the usage of the two different classes depending 
> on what the purpose is, be it a directory or a file.  This does change the 
> interface to instantiation of classes such as IndexReader with a 
> DirectoryInfo object as opposed to a FileInfo object which is more precise 
> and actually cleans up the internals a bit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to