The issue is with the comment, not the code. You will see the same comment
with the Java version in 2.3.1 and 2.3.2. However, if you look in the
trunk, you will see that the following comment were added:
if (this.hasChanges || this.isCurrent()) {
// this has changes, therefore we have the lock and don't need to
reopen
// OR: the index in the directory hasn't changed - nothing to do here
return this;
}
Apparently, someone else on the Java side of Lucene had the same confusion,
and thus the comment was fixed. This change was done on April 11, with the
SVN commit comment of "clarify slightly confusing comment". :-)
-- George
> -----Original Message-----
> From: Eran Sevi [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, June 25, 2008 8:09 AM
> To: lucene-net-user@incubator.apache.org
> Subject: Re: Apache Lucene.Net.2.3.1 build 001 "Alpha" is now
> available
>
> Hi George,
>
> That you very much for your effort.
>
> We are counting on Lucene.Net as the foundation for our next
> release of enterprise application and very happy to see the
> new version.
> Your skill and time are much appreciated.
>
> I started going over the code to check out the new features
> and changes and found the following:
>
> In class DirectoryIndexReader, method Reopen() -
>
> the condition for not re-opening the IndexReader is:
>
>
> if (this.hasChanges || this.IsCurrent())
>
> {
>
> // the index hasn't changed - nothing to do here
>
> return this;
>
> }
>
>
> shouldn't it be " ! hasChanges" instead of hasChanges?
> I haven't run the code and found it just from looking at the files.
> I'm not that familiar with the inside of the files and might
> be wrong but what do you think?
>
> Thanks,
> Eran.
>
> On Wed, Jun 25, 2008 at 6:14 AM, George Aroush
> <[EMAIL PROTECTED]> wrote:
>
> > Hi folks,
> >
> > If you are subscribed to the commit notifications mailing list
> > (lucene-net-commits[AT]incubator.apache.org), by now you must have
> > received several emails of new check-in's. No, it's not spam, it's
> > Lucene.Net coming back to life again.
> >
> > As many of you know, as of December 2007, soon after when I labeled
> > Lucene.Net 2.1 as "Release Candidate", I stopped working and
> > commenting on this project. This was a difficult decision
> for me to
> > make because, my work on Lucene.Net is done during my free time
> > without any compensation -- this isn't easy to keep up with due to
> > family and work obligation. Since then, I have received several
> > emails encouraging me to continue effort and as of few
> months ago, I
> > have been silently (and slowly) working on porting Lucene
> > 2.3.1 to C# with the help of folks from MySpace.com. So, I'm back
> > re-committed to this project. However, I want to make it
> clear that
> > I'm still doing so on my own free time with no compensation [1].
> >
> > With the help of Doug Sale of MySpace.com, we now have Apache
> > Lucene.Net
> > 2.3.1 "Alpha" available. Doug, took my initial raw port of
> Lucene.Net
> > 2.3.1, and got it to a compilable and runnable state. This
> saved me a
> > lot of time and allowed me to work on porting the Test code, which
> > Doug also took over and got it to a compilable and runnable
> state. As
> > a result, we now have Lucene.Net 2.3.1 "alpha"; here is the release
> > notes about it (which is in the HISTORY.txt file):
> >
> > 24Jun08:
> > - Dev Release: Apache Lucene.Net.2.3.1 build 001 "Alpha"
> > - Port: Ported teh "Core" and "Demo" code from Java to C#.
> > - Issues: Test code is not released yet.
> > - Note: Requires Visual Studio 2005 or later and
> .NET 2.0 or later.
> > - Note: There is no 2.3.0 or 2.2 release (to correspond with
> > the Java Lucene release).
> >
> > Please grab a copy from SVN and give it a spin.
> >
> > Looking ahead, lets work together to keep Lucene.Net back in shape
> > again and prepare it for graduation. This, requires that
> we build a
> > community as well as nominate folks for committership. Doug Sale
> > defiantly qualifies, as well as DIGY who was very active addressing
> > port issue with Lucene.Net 2.1. If anyone wants to gain
> committership
> > status, this is your chance to participate toward that effort.
> >
> > Best regards,
> >
> > -- George
> >
> >
> > [1] If anyone has side projects in which I can offer my services,
> > please don't hesitate to contact me at [EMAIL PROTECTED] Thanks!
> >
> >
>
