On Mon, 2014-07-07 at 11:09 -0400, Dwight Engen wrote: > On Sat, 05 Jul 2014 11:25:57 -0400 > "Michael H. Warfield" <[email protected]> wrote: > > > On Sat, 2014-07-05 at 10:09 -0400, Michael H. Warfield wrote: > > > On Sat, 2014-07-05 at 10:03 +0200, Johannes Kastl wrote: > > > > Hi Michael, > > > > > > > > sorry for the delay, I was kinda busy... > > > > > > > > On 18.06.2014 19:15 Michael H. Warfield wrote: > > > > > > > > > I'd really like to look at your changes for lxc.spec but I may > > > > > not be able to do much with it over the next week. With luck, > > > > > we may soon see OpenSUSE images for the download template. > > > > > > > > You can find my working version here: > > > > > > > > > https://build.opensuse.org/package/view_file/home:ojkastl_buildservice:LXC/lxc-vanilla/lxc.spec?expand=1 > > > > > > > > I > > > > > > > > > wanted to split up the changes into > > > > - needed for opensuse (different package names, etc.) > > > > and > > > > - unnecessary / wrong includes (at least according to the openSUSE > > > > build service). > > > > > > I'd like a little more detail about what you're referring to there. > > > Specifically, if the openSUSE build service doesn't like something, > > > I would like to see the specific errors that it's generating. > > > > > > In diffing your lxc.spec against the stock 1.0.4 build I see some > > > changes that I would consider to be largely cosmetic like this: > > > > > > 83c109,110 > > > < Requires: %{name} = %{version}-%{release}, pkgconfig > > > --- > > > > Requires: %{name} = %{version}-%{release} > > > > Requires: pkgconfig > > > > > > and this: > > > > > > 56,57c58,83 > > > < Requires: openssl rsync > > > < BuildRequires: libcap libcap-devel docbook2X graphviz > > > --- > > > > Requires: openssl > > > > Requires: rsync > > > > > > > > %if 0%{?fedora} >= 14 || 0%{?rhel} >= 7 > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > Testing builds for Oracle and CentOS 6 run fine without this > > restriction on rhel level. I'm lead to the conclusion that the above > > line is wrong.
> Hi Mike, I added that to make sure we packaged the correct init script. I
> think the rpm will build without it, but we might package the wrong
> init script. If you think its not needed now though because we
> automatically build/install the right things through configure.ac I'm
> fine if you want to remove/rework the with_systemd logic from the .spec.
I think around the init scripts it's probably fine but it's where he
added it around some of the BuildRequires is where I was questioning.
My diff was between the 1.0.4 lxc.spec and his SUSE lxc.spec but I will
double check.
> > I did have to install docbook2X and the lua components from EPEL for
> > both CentOS and Oracle, which may give some people some heartburn but
> > LXC is an EPEL component on those platforms anyways. I was able to
> > find python3 for CentOS 6 from the SC (Software Collections)
> > repository but have not found it for Oracle yet. That a significant
> > source of heartburn there but we loose too much functionality
> > otherwise.
> >
> > That was testing with the stock 1.0.4 lxc.spec file. I'm continuing
> > to review your changes and seeing about integrating them. Now that
> > I've regression tested my 4 rpm based test environments (Fedora,
> > CentOS, Oracle, openSUSE), I can start to look at integrating your
> > changes.
> >
> > > > BuildRequires: libcap
> > > > BuildRequires: libcap-devel
> > > > BuildRequires: docbook2X
> > > > BuildRequires: graphviz
> > > > %endif
> >
> > Regards,
> > Mike
> >
> > > Does that openSUSE build system require the "BuildRequires" be on
> > > unique individual lines? I have no heartburn with breaking the
> > > lines into multiple BuildRequires but I am curious if it was
> > > necessary or merely a "style" issue.
> > >
> > > I'm also more than a little concerned about that later set of
> > > changes, since that materially impacts builds on CentOS 6 ({%rhel}
> > > == 6) and possibly Oracle 6 but I haven't tested those builds in a
> > > long while and I should probably test it. It has known problems
> > > anyways due to lua and python3 missing.
> > >
> > > I have no problem with those changes and harmonizing the two in the
> > > sources would be fine. Dwight should probably also review this as
> > > well as this could impact the Oracle builds.
> > >
> > > > But atm I do not have time for this, I hope to come back to this
> > > > issue in a few weeks. Sorry.
> > >
> > > > Oh, and I have not updated the changelog (at the end of the file)
> > > > to a recent version...
> > >
> > > > Regards,
> > > > Johannes
> > >
> > > Regards,
> > > Mike
Thanks!
Regards,
Mike
--
Michael H. Warfield (AI4NB) | (770) 978-7061 | [email protected]
/\/\|=mhw=|\/\/ | (678) 463-0932 | http://www.wittsend.com/mhw/
NIC whois: MHW9 | An optimist believes we live in the best of all
PGP Key: 0x674627FF | possible worlds. A pessimist is sure of it!
signature.asc
Description: This is a digitally signed message part
_______________________________________________ lxc-devel mailing list [email protected] http://lists.linuxcontainers.org/listinfo/lxc-devel
