Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak Younes: > I don't need to know. I am just moving code around and this should just > work. I am quite confident actually that it _will_ just work.
OK, suppose it works. Then there is still the problem that this is supposed to be a cleanup, but obfuscates the code for somebody who knows X selection better. It is standard X terminology to request or clear a selection, so a sensible cleanup IMO would be to rename selectionRequested to requestSelection and selectionLost to clearSelection. The clipboard is a bit different, there we have an abstraction over windows and unix clipboards, so we don't need to follow either terminology too closely. > No need for X knowledge, just need someone who test if the selection > works or not, that' all. IMO you need X knowledge if it should be really a cleanup and not arbitrary code shuffling around. Georg
