>>>>> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes:

Michael> Jean-Marc Lasgouttes schrieb: Jean-Marc, attached please find
Michael> a simple patch that improves CT in LyX 1.4. Essentially, the
Michael> patch consists of three parts:
>>  Michael, as I told you yesterday, I think we should skip this
>> patch for 1.4.3.
Michael> Did you? I remember you said you like the patch.

Yes, I like the patch. But I think it is too late in release schedule.
Maybe I did not write it.

>> Also, after I looked at implementing getStatus for accept/reject
>> change, I found out that these lfuns are not suited for public
>> consumption (they assume that the current selection is exactly one
>> change, whereas it should apply to the change at cursor or all
>> changes in selection (which can be of different types.
>> 
Michael> I think I tested it. I will re-check it this evening.

I the selection comprises both selections and deletions, the user will
assume that all these changes will get apply. I think the real result
will be weird.

>> This points out why I really really should not accept seemingly
>> trivial patches that come out of nowhere a few days before release
>> :)
>> 
Michael> Shame on me :-(

No, shame on me probably.

JMarc

Reply via email to