Abdelrazak Younes wrote:
> Index: buffer.C
> ===================================================================
> --- buffer.C (revision 15153)
> +++ buffer.C (working copy)
> @@ -1480,12 +1477,13 @@
> params().parentname = name;
> }
>
> -
retain the two spaces please.
> +// FIXME getMasterBuffer() has no business here!
> +// should be transfered to BufferList.
> Buffer const * Buffer::getMasterBuffer() const
This comment is wrong. getMasterBuffer returns the master buffer of a
multipart document, not some "global master buffer" (see also the
documentation in buffer.h). It has nothing to do with bufferlist.
> {
> if (!params().parentname.empty()
> - && bufferlist.exists(params().parentname)) {
> - Buffer const * buf =
> bufferlist.getBuffer(params().parentname);
> + && theApp->bufferList().exists(params().parentname)) {
> + Buffer const * buf =
> theApp->bufferList().getBuffer(params().parentname);
> if (buf)
> return buf->getMasterBuffer();
> }
> @@ -1494,11 +1492,13 @@
> }
>
>
> +// FIXME getMasterBuffer() has no business here!
> +// should be transfered to BufferList.
see above.
> Index: buffer_funcs.C
> ===================================================================
> --- buffer_funcs.C (revision 15153)
> +++ buffer_funcs.C (working copy)
> @@ -175,12 +173,12 @@
> return false;
> }
>
> -
> +// FIXME newFile() should be a member method of Application or
> BufferList?
Not bufferlist IMHO. Bufferlist simply holds a list of open buffers.
I don't have any further complaints ;-)
Georg
