On Sun, Oct 15, 2006 at 11:26:17PM +0200, Joost Verburg wrote: > The attached patch solves the problem: > > * When running on Windows, configure.py will not detect viewers and let > Windows handle it (write 'auto'). When an external application handles > auto-detection, a viewer entry can be added. > > * Auto-detection inside LyX will use the OS viewer when configure.py has > returned 'auto'. Again this is always the case on Windows except some > special application handles auto-detection. > > * It makes configuration faster because configure.py does not attempt to > detect UNIX applications on Windows. > > Comments? If this is acceptable, I will write a "pdfview" application to > improve PDF viewing on Windows.
No, this is not acceptable because you are changing the behaviour on the other systems (currently only cygwin and OSX). With your change, when configure.py detects an application, the system default is never used. This means that one is forced to use the applications which are searched for in configure.py instead of the OS defaults. Moreover, I think that configure.py should still try to find some suitable application for a given task, such that, when no defaults are set in the OS, the ones find by the lookup can be used. I mean that it is an error to not let configure.py search for applications even on Windows, and rather I would restore the application names specific to Windows which were removed... -- Enrico
