Am Sonntag, 22. Oktober 2006 10:39 schrieb Abdelrazak Younes: > Georg Baum wrote: > > Am Samstag, 21. Oktober 2006 17:50 schrieb Abdelrazak Younes: > >> Georg Baum wrote: > >>> Am Samstag, 21. Oktober 2006 16:43 schrieb Asger Ottar Alstrup: > >>> > >>> > >>> Maybe you should also talk about why the current state is like it is. > >> Just for clarification, I hope you don't mean that it is my fault. My > >> cleanup work have always been pretty careful and the general Cut&Paste > >> and undo/redo that we see now is not due to this cleanup at _all_. > > > > It is partly your fault. > > And yours also.
Sure. I never said that I only write bugfree code. > You have introduced a number of big changes in the code. I don't remember big changes apart from unicode stuff (but I may be wrong). The InsetCommandParams change was not big IMO, it is restricted to a small number of insets. > Personally I think your InsetParams changes did introduce more hidden > bugs than my cleanups. But the bigger source of bugs is the unicode > transition, period. As I stated on Friday I am aware of one index problem, and I still have to finish the lyx2lyx conversion. I promised to do that soon and I will do that. But apart from that I don't expect new problems. The changes I committed yesterday where done by Ugras, and I reviewed them (and fixed one or two problems), so that should be pretty safe. > > Cleanup work like yours introduces bugs no matter > > how careful you are. I guess that parts of the current problems are > > something else and some of your bugs are not yet known. > > Come on... Bugs related to display and frontends are quickly discovered > and I have fixed all reported problems due to my cleanups. You were always very responsive to bug reports, that is true, and after I sent my message I thought I should have mentioned that. Therefore I am not too afraid about the bugs resulting from the cleanup work. Nevertheless I am pretty sure that we will discover some more. Georg
