Georg Baum wrote:
Am Sonntag, 29. Oktober 2006 18:10 schrieb Abdelrazak Younes:
Georg Baum wrote:
I am not surprised. You remember my words about multi-window support
and
core changes during Denmark?
Yes, you were right. For my defense, I'd say that there's a lot of ugly
corner cases inside the code ;-)
Everybody knows that ;-)
Did you replace all tests for bv in InsetText with a proper ismainText
call?
There was not many of those test (only in the LyXText constructor I
think). I am not quite sure what you are talking about but I think I
have done some cleanup in the past that eliminated some of these tests.
Good. I did only skim the patch, and I do remember from my try that there
where several explicit
&bv()->buffer()->text() == this
tests where isMainText() was meant insetad. I only wanted to make sure that
these where translated correctly.
Here's what remains:
Find all "text() == this", Match case, Whole word, Subfolders, Find
Results 1, "lyx-trunk",
"*.c;*.cpp;*.cxx;*.cc;*.tli;*.tlh;*.h;*.hpp;*.hxx;*.hh"
src\text2.C(1001): if (cur.top().text() == this)
src\text2.C(1230): BOOST_ASSERT(old.text() == this);
src\text3.C(308): BOOST_ASSERT(cur.text() == this);
src\text3.C(1506): BOOST_ASSERT(cur.text() == this);
Only the first case is important but DocIterator::top() is not about the
top-level LyXText apparently, is it? If no then everything is fine.
Abdel.
