Andre Poenitz wrote:
> On Tue, Nov 14, 2006 at 01:08:56AM +0100, Peter Kümmel wrote:
>> Here a totally superfluously patch:
> 
> Erm.
> 
>> +void Splash::finish(int secs)
>> +{
>> +    if (qsp == 0)
>> +            return;
>> +    QTime t = QTime::currentTime().addSecs(secs);
>> +    while (t > QTime::currentTime())
>> +    {
>> +    }
>> +    delete qsp;
>> +}
> 
> A busy loop?

Who cares?

> 
>>      // doubleClickInterval() is 400 ms on X11 which is just too long.
>>      // On Windows and Mac OS X, the operating system's value is used.
>> Index: src/splash.h
>> ===================================================================
>> +
>> +struct Splash
>> +{
>> +    static void show();
>> +    static void finish(int secs);
>> +
>> +private:
>> +    static void init();
>> +};
>> +
>> +} // namespace lyx
>> +
>> +#endif // SPLASH_H
> 
> A class with only statric functions is a namespace.
> 
> Are you aware of QSplashScreen?

Have a look at the patch again.

Peter

P.S.
What's the miracle of your time shifted emails?

Reply via email to