On Tue, Dec 12, 2006 at 03:06:31PM +0100, Georg Baum wrote:
> Jean-Marc Lasgouttes wrote:
>
> > OK, here is the patch. Test it when you can.
>
> Some nitpicks:
>
> > - return fromqstr(qprint(mod));
> > + return from_utf8(fromqstr(QKeySequence(tmpkey).toString()));
>
> Please use
>
> return qstring_to_ucs4(QKeySequence(tmpkey).toString());
>
>
> > + docstring const binding(mi.binding());
> > + if (!binding.empty()) {
> > + label += char_type('\t') + binding;
>
> label += \t' + binding;
>
> works too and looks better.
It certainly looks too assymetric for my taste...
SCNR,
Andre'
