Jürgen Spitzmüller wrote:
The attached patch fixes that bug, but I'm not sure it is the right approach.

The problem is that bibkeysInfo_ is not cleared. This used to happen in ControlCitation::clearParams() that is called from Dialog::hide().

However, seems that Dialog::hide() as well as Dialog::OKButton() etc. are not triggered anymore, but that the qt4 dialogs are doing their own thing. Abdel, I guess this is intentional?

Yes it was. But I remember calling this clearParams() somewhere. As I don't use bibtex myself, I didn't noticed the problem.


The patch hence calls ControlCitation::clearParams() directly from within QCitationDialog. I wonder, however, if similar problems are not to be found the other dialogs, since clearParams() is implemented there as well and should certainly be triggered.

AFAIR, only the Citation and Toc dialogs have been converted to the Model/View separation.


Opinions?

Put it in.

Abdel.

Reply via email to