Peter Kümmel <[EMAIL PROTECTED]> writes: | Bo Peng wrote: | > What I meant is something like follows. The patch does not work | > correctly yet, but shows my point. | > | > 1. src/bufferlist.C: remove quitWriteBuffer and quitWriteAll. | > | > 2. LFUN_LYX_QUIT triggers LFUN_WINDOW_CLOSE | > | > 3. LFUN_WINDOW_CLOSE triggers LFUN_BUFFER_CLOSE one by one | > | > 4. closeEvent triggers LFUN_LYX_QUIT. | > | > That is to say, no one takes the shortcut quitWriteAll. lyx-close | > experts (Peter, Enrico, Abdel), what do you think? Anything seriously | > wrong here? | | I think, the most important thing when quitting is that there | is one place where all prepare-to-quit code is located. | | Does you patch support this? | How many ways of quitting exit? | 1. menu exit -> LFUN_LYX_QUIT | 2. last window closed -> LFUN_WINDOW_CLOSE -> LFUN_LYX_QUIT
and the third: 3. direct LFUN_LYX_QUIT (short-cut, lyx-server...) But I think you are right. All "quitting" should end up in LDUN_LYX_QUIT and IMHO that should handle closing of the rest of the windows and buffers. -- Lgb