Re: filename with space truncated n external insets dialog

[Bernhard Roider]

Hello!

The attached patch fixes the problem in trunk. The problem was that for the filename one token was 
retrieved from the lexer instead of the whole remaining line.

Bernhard

PS: I think the preferred way for contributing should be via a bug report?

Abdelrazak Younes wrote:
Bernhard Roider wrote:
hi!

first of all: i took a look at 1.5.0 svn and i think it will be a 
great piece of software!

i just recognized that if in the external insets dialog a file name 
containing a space is inserted (or selected with the file open dialog) 
then the name is truncated at the space character after pressing ok.


Confirmed. I guess the problem is in InsetExternalMailer::string2params().

Abdel.



Index: src/insets/insetexternal.C
===================================================================
--- src/insets/insetexternal.C  (revision 16795)
+++ src/insets/insetexternal.C  (working copy)
@@ -290,7 +290,7 @@
                        break;
 
                case EX_FILENAME: {
-                       lex.next();
+                       lex.eatLine();
                        string const name = lex.getString();
                        filename.set(name, buffer.filePath());
                        break;