Michael Gerz wrote:

> Georg,
> 
> common_path in support/os_win32.C triggers an assertion in uppercase(),
> because not all characters are  < 0x80.
> 
> Any idea how to fix this properly?

Yes: Don't use the char version of uppercase(). Unfortunately it is not
possible to get rid of it because of automatic char -> char_type
conversion. I just committed a fix.

> What happens (in worst case) if we 
> remove the assertion in uppercase()?

A secret self destruction function will format your harddrive :-)

Seriously: common_path will not work for paths with umlauts. This could
explain why for some people inserting a figure will always use an absolute
path (makeRelPath uses common_path).

The assertion should not be removed at all, since it helps us to find bugs
like this.


Georg

Reply via email to