On Sat, Mar 17, 2007 at 10:08:38PM +0100, [EMAIL PROTECTED] wrote: > On Sat, 17 Mar 2007, Andre Poenitz wrote: > > >Testcase is src/graphics. Pretty selfcontained, modern C++ the way we > >like it. A total of 2608 lines in 11 *.C files. > > Just a reference point, and in case anyone would like to print the code (I > did this for the NSIS stuff): assuming 70 lines per page, those 2608 lines > would become about 40 pages. Personally I think that'd be too much as a > single document, but I assume you're not suggesting it all go into a > single file, but rather a small set of files?
Well, I did. But not because I want a 2600 line document, but because I see the benefits of faster re-compilation, much faster null builds and 32 MB less diskspace (there's this pch.h.gch thing, too) clearly outweighing the drawbacks. Just some more "numbers": Saving 15s in a null build times 5 active developers times 10 needed builds per feature makes 1500s saved on developper's time, i.e. after a week you got the time needed to implement some little new feature for free. Do you really see this less desirable as having a 2600 lines file lying around somewhere in a corner you never work on? > Currently, for the eleven .C-files, each file would on average print to > about three pages. Do you really print out .C files? Even if so, you should be able to print put parts of a file if that's what you need. > PS. I'm neither for nor against this proposal - I can see advantages to > both points. I start failing to see the advantages of small files. Maybe you can tell me again.. > >PS: On top of that, header files could be merged and the directory > >as a whole could vanish, speeding up make directory recursion. > > Eh... are you actually suggesting to merge all 11 files? That was the proposal, yes. > Hmm... guess I do have an opinon then... I think 2600 lines in one > file is a bit much... Why? Just because LyX usually does not do it? First, there _are_ a few files longer than that already in LyX, secondly, Apache HTTP server has roughly 5% of its files longer than 2000 lines, 25% are longer than 500. Btw, from this 2600 lines roughly 300 vanish as they are duplicated #include and using lines (so far for maintanance...). Moreover, most of the pimpls can go as most of the classes _are_ already implementation details which do not need to hide their implementation details further. I wouldn't be surprised if that bought another 300 lines, resulting in a file with less than 2000 lines. Andre' PS: For some strange reason I have the impression that whenever LyX development get the choice between two options, it chooses the one that hurt most.
