Hi!
This works for me too, so as far as I'm concerned, this should go in
(and thanks, Elazar!). If anyone really objects to using "goto", it
could be implemented by separating the actual functionality into
separate functions --- one for left and one for right, similarly to how
it's done in
http://www.lyx.org/trac/browser/lyx-devel/trunk/src/Text3.cpp#L431.
However, while playing around with this, I see that we have the same
problem with other types of insets (I tested footnotes, I assume it's
the case for most or all insets). It seems sort of a shame, but I guess
there's no alternative to fixing each type of inset separately...? (I
guess what I'm asking is this: is there a good reason for the fact that
the handling of keyboard movement is performed separately in Text3,
MathInsetNest, and I imagine in quite a few other places, rather than
being handled centrally?)
And there are also some other problems with cursor movements around
insets in RTL paragraphs, I opened two new bugs, 3550 and 3551
(http://bugzilla.lyx.org/show_bug.cgi?id=3550,
http://bugzilla.lyx.org/show_bug.cgi?id=3551).
Whoever commits this patch, please close bug #904, but please also add a
comment with a link to the changeset (just so that if we ever do come up
with a solution for all insets at once, we'll know where to go to get
rid of this patch).
Dov
Elazar Leibovich wrote:
My patch "Works for me" very well, the cursor never got stuck.
Can you specify me how to recreate the problem?
On 4/30/07, Elazar Leibovich
<[EMAIL PROTECTED]> wrote:
Hmm... I'll look at it. But what can cause this? Is it still
recognizing we're in RTL there? My code simply reverse the dispatcher
signal.
On 4/30/07, Abdelrazak Younes <[EMAIL PROTECTED]>
wrote:
> Elazar Leibovich wrote:
> > Hold on. It does segfaults, but this is not me, this is the isRTL
> > function implemented in Cursor.cpp. It's fails when it tries to ask a
> > LyxText from the CursorSlice it occurs in.
> > Can someone help me fix this function?
>
> It's fixed now. I've tried your patch, it seems to fix the problem when
> leaving the inset at the end of the equation (so on the right). In this
> case the cursor automatically goes after the equation in RTL mode
(so on
> the left).
> There is still a problem when leaving the equation at the beginning of
> the equation. The cursor is trapped there.
>
> Abdel.
>
>
