Dov Feldstern wrote:
Hi!
This works for me too, so as far as I'm concerned, this should go in
(and thanks, Elazar!). If anyone really objects to using "goto", it
could be implemented by separating the actual functionality into
separate functions --- one for left and one for right, similarly to how
it's done in
http://www.lyx.org/trac/browser/lyx-devel/trunk/src/Text3.cpp#L431.
Patch welcome ;-)
While 'goto' use is in general not recommend, it is relatively clean in
this case... opinions?
Andre and JMarc talked about cleaning up a bit the two relevant insets.
However, while playing around with this, I see that we have the same
problem with other types of insets (I tested footnotes, I assume it's
the case for most or all insets). It seems sort of a shame, but I guess
there's no alternative to fixing each type of inset separately...? (I
guess what I'm asking is this: is there a good reason for the fact that
the handling of keyboard movement is performed separately in Text3,
MathInsetNest, and I imagine in quite a few other places, rather than
being handled centrally?)
In principle there are only those two. We cannot avoid having two
different way of navigation within mathed or within texted.
InsetFootnote contain a text inset so it should use the code in
'Text3.cpp'. So the problem lies elsewhere and needs to be investigated.
And there are also some other problems with cursor movements around
insets in RTL paragraphs, I opened two new bugs, 3550 and 3551
(http://bugzilla.lyx.org/show_bug.cgi?id=3550,
http://bugzilla.lyx.org/show_bug.cgi?id=3551).
Whoever commits this patch, please close bug #904, but please also add a
comment with a link to the changeset (just so that if we ever do come up
with a solution for all insets at once, we'll know where to go to get
rid of this patch).
I will make sure that one solution or another is in before 1.5.0 but I
am not going to commit it now. Waiting for input from JMarc and Andre'.
Abdel.
