On Wed, May 16, 2007 at 12:32:34PM +0200, Jean-Marc Lasgouttes wrote: > >>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Abdelrazak> Hum the version I committed from JMarc used the > Abdelrazak> CursorSlice::operator<() which does not check for idx() > Abdelrazak> IIRC. Should add this test JMarc? > > I double checked and it does check for idx. However, I see now that > any container implements lexicographic ordering tests. Question: would > the following patch make sense? Abdel, I know I have removed code > you just added, but I am wondering why we have to declare those extra > things. Also, it seems to me that the following could be removed: > > /// test for inequality > bool operator!=(CursorSlice const &, CursorSlice const &); > /// test for order > bool operator>(CursorSlice const &, CursorSlice const &); > /// test for order > bool operator<=(CursorSlice const &, CursorSlice const &); > > Andre', am I right?
If it is not used it surely can be removed. Containers require < and == at most. Andre'
