On Dec 23, 2007 3:20 PM, Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > > "Bo Peng" <[EMAIL PROTECTED]> writes: > > >> I just tested it. It looks good. One thing I noted: If the document > >> contains > >> multiple unknown characters, only the first one is reported by the error > >> dialog. Is this intended? > > > > Right now, the exception will stop the export process so only the > > first unknown character is reported. If we want to report all of them, > > ErrorList has to be passed to a deeper level which would lead to a > > more intrusive patch. I chose the simpler solution because I think it > > is good enough to fix such problems one by one. > > The way the system works for all other errors is that they do not stop > the execution. Please at least add FIXMEs explaining that the > solution is suboptimal.
There are iconv_codecvt_facet_exception, std::exception that will stop the export process. EncodingException is just another exception that might be thrown during the process. I agree that it would be nice to show all offending characters, but it is perfectly fine to me to show only the first one. This might be an reaction to the fact that I usually only need to locate (the hard part) and fix the first compiling error when gcc gives pages of error messages. I will explain the situation with a comment. Cheers, Bo
