[EMAIL PROTECTED] writes:
> Author: forenr
> Date: Sat Jul 26 12:45:38 2008
> New Revision: 25898
>
> URL: http://www.lyx.org/trac/changeset/25898
> Log:
> Automate setting of LYX_DIR_XXx and LYX_USERDIR_XXx environment variable
> names.
This is a good thing, although it does not remove the need to update
the documentation and manpage as needed.
> dnl Extract the single digits from PACKAGE_VERSION and make them available.
> -dnl Defines LYX_MAJOR_VERSION, LYX_MINOR_VERSION, LYX_RELEASE_LEVEL, and
> -dnl LYX_RELEASE_PATCH, the latter being possibly equal to 0.
> +dnl Defines LYX_MAJOR_VERSION, LYX_MINOR_VERSION, LYX_RELEASE_LEVEL,
> +dnl LYX_RELEASE_PATCH (possibly equal to 0), LYX_DIR_VER, and
> LYX_USERDIR_VER.
Is it really necessary to both #define and SUBST these variables?
> + lyx_dir_ver=`echo LYX_DIR_${lyx_major}${lyx_minor}x`
> + lyx_userdir_ver=`echo LYX_USERDIR_${lyx_major}${lyx_minor}x`
Why not just the following?
+ lyx_dir_ver=LYX_DIR_${lyx_major}${lyx_minor}x
+ lyx_userdir_ver=LYX_USERDIR_${lyx_major}${lyx_minor}x
JMarc
