Attached are two patches. Both are physically large but very simple.
patch_insets
==========
In patch_insets, I modified the Inset::Clone method, so that it is passed a
Buffer const & parameter. I also modified all Inset c-tors that are passed a
Buffer *. They are now passed a Buffer const & also (it is impossible tfor an
inset to be created without a buffer, so this is ok).
Net result is to fix a bug with those insets that store a Buffer * and pass
this on to a Cloned inset.
I did not modify LyXParagraph to store a Buffer *. This patch is way big
enough already! Consequently, the Inset::Clone() methods are passed a
current_view->buffer(). Don't worry; this will change.
With this patch, current_view is eliminated almost entirely from the
subdirectories. It exists only in a couple of inset classes that are slated
either for removal or for the GUI-I treatment.
patch_xforms
==========
the updateBufferDependent signal is now connected to
FormBase::updateOrHide(). If the daughter class should ALWAYS be updated when
the buffer changes, this is flagged by an enum passed to the FormBase c-tor.
If it should hide when the buffer changes, then the enum reflects this.
I consider both patches to be bug fixes, so would like them applied before
1.1.6.
Angus
patch_insets.bz2
patch_xforms.bz2
