>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> The attached patch removes those "conversion to integral type
Angus> of smaller size" warnings from a couple of files in src/insets.
Angus> This directory now compiles cleanly.
Angus> On Sat, 14 Oct 2000, Lars Gullik Bj�nnes wrote:
>> One small comment: when you know the type to be "large enough" we
>> can use this style of casting: int(str.length()); instead of
>> static_cast<int>(str.length());
Angus> Thanks for the hint, Lars.
Angus, did you check in all places that the values for positions, etc
are always positive? Currently LyXParagraph::size_type is signed, but
this will probably change later. This has the potential for creating
problems: in particular when comparing signed and unsigned values.
So, I'd rather be sure you doublechecked it before applying the patch
(in fact this was the reason why I did not make the changes myself :).
JMarc
