On Mon, 16 Oct 2000, Angus Leeming wrote:
> > For cursor positions and such, you should definitely use
> > LyXParagraph::size_type. If you happen to need a signed version of
> > this, then you should define LyXParagraph::difference_type.
>
> Jean-Marc, I've checked the code. It turns out (by chance!) that the only
> stuff I changed to LyXParagraph::size_type does indeed refer to cursor
> positions. The patch can, therefore, be applied.
>
> Perhaps it would make the code clearer if the name of this variable was
> changed to LyXParagraph::position?
>
> > For example, in insetcite.C, the uses of size_t should be replaced by
> > string::size_type or something like that.
>
> Thanks for the info, Jean-Marc. I'll have a look.
>
> Angus
I've re-done the original patch, fixed insetcite.C (and undid an earlier
change!), now that I understand the philosopy behind the various types. Many
thanks again for the explanation, Jean-Marc.
Angus
patch.bz2
