Am 19.11.2010 22:29, schrieb Georg Baum:
It
implements a new inset for subscript and superscript in text mode, including
correct output for all backends. There are some other ideas discussed in
http://www.lyx.org/trac/ticket/3008, but the inset approach is the best one
IMO.
Almost perfect! I stress-tested your patch and it works very in all situations that came into my
mind. However, some minor annotations:
- I would rename the images from
inset-insert_script_script_***script.png
to
inset-insert_script_***script.png
- The images are not yet used. Where do you plan to use them?
- Changing text from/to subscript should also be possible via the text style dialog. Users expect
this because Word/OpenOffice and Co. also provide this.
May the patch go in at this stage (I don't know
how the current policy is)? The risk of breakage is close to zero. The only
code that is touched besides the new inset is the cursor positioning in
Text::dispatch() after inserting a new inset: If the inset is a text inset,
the inset is entered instead of positioning it behind the inset, since this
is consistent with ERT insets etc.
I fully support you here. Sub/superscript is an essential feature for a word processor and we only
provide a hack. I know that this feature is a bit late since beta1 is out, but it is indeed very low
risk applying it. I also assume that you will fix probable bugs in this feature quickly as Pavel
requested.
So I vote to include it.
Jürgen also voted for it in the bug report.
best regards
Uwe
p.s. I hope you will return at least from time to time to LyX. We really need your strong knowledge
and exact working style. I remember your patches as always well tested with clean and well
understandable! code.
