Am 15.12.2010 um 23:16 schrieb Jean-Marc Lasgouttes:
> Le 15/12/2010 22:36, Stephan Witt a écrit :
>> I tried to compile LyX with -pedantic option.
>>
>> Most warnings are easy to fix. See the attached patch.
>
> The patch looks correct, except for some of the casts in .m files (but
> they can probably not be avoided).
Later I found the correct solution for one of them:
The rate argument is a double value (NSTimeInterval is double)!
Index: src/support/linkback/LinkBack.m
===================================================================
--- src/support/linkback/LinkBack.m (Revision 36898)
+++ src/support/linkback/LinkBack.m (Arbeitskopie)
@@ -111,7 +111,7 @@
return [self linkBackDataWithServerName: serverName appData: appData
actionName: LinkBackRefreshActionName suggestedRefreshRate: rate] ;
}
-+ (NSDictionary*)linkBackDataWithServerName:(NSString*)serverName
appData:(id)appData actionName:(NSString*)action
suggestedRefreshRate:(NSTimeInterval)rate ;
++ (NSDictionary*)linkBackDataWithServerName:(NSString*)serverName
appData:(id)appData actionName:(NSString*)action
suggestedRefreshRate:(NSTimeInterval)rate
{
NSDictionary* appInfo = [[NSBundle mainBundle] infoDictionary] ;
@@ -133,7 +133,7 @@
if (action) [ret setObject: action forKey: LinkBackServerActionKey] ;
if (appData) [ret setObject: appData forKey:
LinkBackApplicationDataKey] ;
if (url) [ret setObject: url forKey: LinkBackApplicationURLKey] ;
- [ret setObject: [NSNumber numberWithFloat: rate] forKey:
LinkBackSuggestedRefreshKey] ;
+ [ret setObject: [NSNumber numberWithDouble: rate] forKey:
LinkBackSuggestedRefreshKey] ;
return [ret autorelease] ;
}
Am 15.12.2010 um 23:36 schrieb Enrico Forestieri:
>>>
>>> But one isn't that easy:
>>>
>>> src/frontends/qt4/GuiProgressView.cpp: In member function 'void
>>> lyx::frontend::GuiProgressView::debugSelectionChanged()':
>>> src/frontends/qt4/GuiProgressView.cpp:149: warning: overflow in implicit
>>> constant conversion
>>>
>>
>> Don't know.
>
> Try replacing "int level" with "unsigned int level".
That works. Thanks.
I think, the more correct change would be to use the position index of the
debug type in GUI and convert them to the debug type value on user
interaction...
I'll prepare a patch for that.
Stephan
