Am Donnerstag, 26. Mai 2016 um 17:16:30, schrieb Scott Kostyshak <skost...@lyx.org> > On Thu, May 26, 2016 at 06:44:39PM +0200, Kornel Benko wrote: > > Am Mittwoch, 25. Mai 2016 um 16:48:58, schrieb Kornel Benko <kor...@lyx.org> > > > Am Montag, 23. Mai 2016 um 18:03:27, schrieb Scott Kostyshak > > > <skost...@lyx.org> > > > > On Mon, May 23, 2016 at 03:55:59PM +0000, Guenter Milde wrote: > > > > > On 2016-05-23, Kornel Benko wrote: > > > > > > Am Montag, 23. Mai 2016 um 07:36:53, schrieb Guenter Milde > > > > > > <mi...@users.sf.net> > > > > > >> On 2016-05-22, Scott Kostyshak wrote: > > > > > > > > > > >> > Uwe and Georg have recently found and fixed a bug in our > > > > > >> > internal XHTML > > > > > >> > export. Why not test the export automatically? > > > > > > > > > > ... > > > > > > > > > > > I have a patch ready. > > > > > > > > > > Fine, thanks. > > > > > > > > > > > But now many of xhtml export tests are failing. > > > > > > > > > > This should not deter us from proper testing, should it? > > > > > > > > In my opinion, the important thing is to make sure no new tests go from > > > > passsing to failinig. It is possible to easily catch future regressions > > > > with the tests. I agree with you (below) that inverting a lot of tests > > > > makes sense. This way, we can (1) catch new regressions and (2) if > > > > someone does come along and wants to give some love to the HTML export > > > > we can easily provide them with some places to start (in addition to the > > > > trac bugs we have). > > > > > > > > Scott > > > > > > > > > > > > > > Do you have a list of failing tests? > > > > > > Yes, I have. But the list is huge. > > > 48% tests passed, 186 tests failed out of 356 > > > > > > > > Did you check for the failure reasons? > > > > > > Some of them are really bad, like in doc/MergedManuals.xhtml:9270 > > > <<pre></pre> class="verbatim"><a id='magicparlabel-1955' /><p > > > class="verbatim_item">This is Verbatim.</p> > > > > > > others are OK in firefox. > > > > > > > > I may be we have to invert a lot of tests until the HTML export is > > > > > fixed. > > > > > Maybe we can also introduce a flag for "half-OK" (not passing the > > > > > xmllint test > > > > > but opening OK in a browser). > > > > > > > > > > No, for this the number of failures is too big IMHO. > > > > Hm, using xmllint with the '--sax' parameter shows no errors. Still > > MergedManuals.xhtml is erroneous (e.g. not displayable in firefox). > > Checking the includes, the error is in UserGuide.lyx. > > It turns out that our xhtml cannot handle verbatim environment. > > > > Attached a minimal example: > > > > Richard could you have a look at it? > > Josh (now CC'ed), I remember that at some point you made some fixes to > our XHTML export. Are you by chance interested in working on it further? > We are considering implementing tests for our XHTML export but they are > only useful if we have someone who might be interested in fixing bugs > that our tests find. No pressure at all, just curious if that would be > fun for you. > > Scott
I found the cause in layouts. With the attached patch for the verbatim and code
insets are making some tests happy.
Korneldiff --git a/lib/layouts/jss.layout b/lib/layouts/jss.layout index 47e3dae..1055043 100644 --- a/lib/layouts/jss.layout +++ b/lib/layouts/jss.layout @@ -226,7 +226,7 @@ Style "Code" Series Bold Color Green EndFont - HTMLTag <pre></pre> + HTMLTag pre HTMLItem p End diff --git a/lib/layouts/stdlayouts.inc b/lib/layouts/stdlayouts.inc index 8be0d24..dbde134 100644 --- a/lib/layouts/stdlayouts.inc +++ b/lib/layouts/stdlayouts.inc @@ -91,7 +91,7 @@ Style Verbatim Font Family Typewriter EndFont - HTMLTag <pre></pre> + HTMLTag pre HTMLItem p End
signature.asc
Description: This is a digitally signed message part.
