On Sat, May 19, 2018 at 10:46:59AM +0200, Jean-Marc Lasgouttes wrote: > Le 18/05/2018 à 22:14, Enrico Forestieri a écrit : > > > preview3.diff looks like the cleanest approach to me. I think it should go > > > in. > > > > Unfortunately, it does not work, as already said. It would have been > > surprising if it had worked, though, as the added condition is already > > catched by "pimpl_->status_ != WaitingToLoad". > > I meant preview2, actually. What is wrong with it?
Loader::startLoading() calls Loader::Impl::startLoading(), which in turn calls CacheItem::tryDisplayFormat(). In preview2.diff the conversion is aborted in CacheItem::tryDisplayFormat(), while I think that, from a logical point of view, it is better done in Loader::startLoading(). -- Enrico
