On 22/11/2018 10:38, Daniel wrote:
On 16/11/2018 15:41, Daniel wrote:
On 31/10/2018 18:20, Daniel wrote:
On 31/10/2018 17:46, Daniel wrote:
On 31/10/2018 15:25, Daniel wrote:
On 31/10/2018 07:57, Daniel wrote:
On 31/10/2018 07:24, Daniel wrote:
On 30/10/2018 21:23, Daniel wrote:
On 30/10/2018 17:37, Daniel wrote:
On 30/10/2018 16:46, Scott Kostyshak wrote:
On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote:

Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many
other apps have fixed height find dialogs.

Ah I see. Thanks for the explanation. Seems reasonable to me.

Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs.

Daniel

Spellchecker dialog.

Thesaurus dialog.

Compare dialog.

Preferences dialog. (This might be a more controversial change.)

Messages Pane.

Search & Replace Advanced. A bit more extensive changes.

Just stumbled upon a misplaced spacer in the Table Insert dialog. Patch and screen captures attached.

Daniel

I suggest a fixed minimum height for the Text Properties dialog.

Reasons:
- It cannot profit from greater height
- It might not have its minimum height initially and hence look awkwardly stretched

Daniel

And the patch ...
>From 48176e2a4f695a8e65033a1e4c58a6037cf80092 Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller <d....@web.de>
Date: Thu, 22 Nov 2018 10:40:09 +0100
Subject: [PATCH] Set fixed minimal height for Text Properties dialog.

---
 src/frontends/qt4/GuiCharacter.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/frontends/qt4/GuiCharacter.cpp 
b/src/frontends/qt4/GuiCharacter.cpp
index 8b7f3e83d3..bccd3e6115 100644
--- a/src/frontends/qt4/GuiCharacter.cpp
+++ b/src/frontends/qt4/GuiCharacter.cpp
@@ -211,6 +211,9 @@ GuiCharacter::GuiCharacter(GuiView & lv)
 {
        setupUi(this);
 
+       // fix height to minimum
+       setFixedHeight(sizeHint().height());
+
        connect(buttonBox, SIGNAL(clicked(QAbstractButton *)),
                this, SLOT(slotButtonBox(QAbstractButton *)));
        connect(autoapplyCB, SIGNAL(stateChanged(int)), this,
-- 
2.17.0.windows.1

Reply via email to