Nice work! I'm going to build the 2.3.5 tarball probably today. I'll use
the old installer for the official one, but we can release 'testing'
installers built from this code, as well (including the 64 bit binary).
We can advertise those just on the lists, as we did the last time. That
should get us a fair amount of testing.

Riki



On 6/1/20 8:56 AM, Yu Jin wrote:
> Am Mo., 1. Juni 2020 um 14:01 Uhr schrieb Kornel Benko <kor...@lyx.org
> <mailto:kor...@lyx.org>>:0
>
>     From what I can see, the patch adds only Windows install in extra dir.
>
>     The duplication of language-files
>             development/Win32/packaging/installer2/src/lang/*.nsh
>     vs
>             development/Win32/packaging/installer/lang/*.nsh
>
>     looks not so pleasant. Do we really have to expect different
>     translations in
>     these directories?
>
>
> The translations should be exactly the same, I did not change any
> strings. Why I made a second lang dir though is, mainly because of the
> strings $(EnterLaTeXFolder) and $(EnterLaTeXFolderNone). In the
> current Installer they write new lines as "\r\n", I had to change that
> to "$\r$\n" (NSIS conform) due to recreating the custom LatexFolder
> page with NSDialogs plugin in NSIS Dialog Designer (currently done
> with deprecated InstallOptions plugin). And these 2 strings are
> actually the only strings to use "\r\n" instead of "$\r$\n" currently.
> I also removed some variables and compile time constants and had to
> adapt the strings to that.
>
> Eugene
>

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to