On 4/10/21 11:49 PM, Scott Kostyshak wrote: > On Thu, Feb 11, 2021 at 11:35:10AM +0200, Yuriy Skalko wrote: >>> I'm all for focusing on 2.4.0 release. So I'll not push yet my commits into >>> newly created branch features/unit-test-adoption. >> >> After some time-out I've pushed my work on unit testing into >> unit-test-adoption branch in features repository. So if you have some free >> time and are interested, please try it. >> >> Here are some notes: >> >> * Now it supports CMake only >> * I've added a short section documenting this in Development manual >> * There are several changes that makes testing easier/possible: >> - (Inset...) made several virtual methods public (as in base class >> Inset) that wrongly were private in several derived classes >> - (lyxfind) made public findOne function to get rid of messagebox >> displaying >> - (ExternalTransforms) throw an exception instead of direct output to >> lyxerr stream to get clean console output when running tests > Would it make sense to just merge this to master to reduce the diff > between 2.4.x and later master? No problem if that would not be a good > idea.
At this point, I'm reluctant to change anything in master that isn't bug fixing, unless it is super-safe. I'm not sure what is and isn't here. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel